Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure module is present in built wheel #160

Merged
merged 1 commit into from
May 21, 2024
Merged

ensure module is present in built wheel #160

merged 1 commit into from
May 21, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented May 20, 2024 •
edited
Loading

Description

attempt to resolve build issues that prevent importing stsci.tools when installing from the wheel (spacetelescope/stsci.skypac#72 (comment))

❯ pip install stsci.tools
❯ python -c "import stsci.tools"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'stsci.tools'

closes #161

@zacharyburnett zacharyburnett self-assigned this May 20, 2024
@github-actions github-actions bot added the tests label May 20, 2024
@github-actions GitHub Actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@zacharyburnett
Copy link
Collaborator Author

doing import tools works, instead of import stsci.tools

@pllim
Copy link
Contributor

pllim commented May 20, 2024

Are you sure the OpenAstronomy stuff works on namespace packages? 👀

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented May 20, 2024 •
edited
Loading

Are you sure the OpenAstronomy stuff works on namespace packages? 👀

it seems to work fine with tests on stsci.stimage and stsci.image, though there it is the cibuildwheel version.

However, this same issue occurs locally (#161) so I don't think it's an issue with the workflow

@zacharyburnett zacharyburnett changed the title fix wheel to include stsci.tools fix namespace issue in wheel May 20, 2024
@zacharyburnett zacharyburnett changed the title fix namespace issue in wheel ensure module is present in built wheel May 21, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review May 21, 2024 13:12
@zacharyburnett zacharyburnett merged commit ed46dc5 into master May 21, 2024
14 checks passed
@zacharyburnett zacharyburnett deleted the fix/build branch May 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zacharyburnett zacharyburnett

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namespace issue when building wheel
2 participants
@zacharyburnett @pllim